Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉Source Okta: unit tests were added #14927

Merged
merged 7 commits into from
Jul 22, 2022
Merged

🎉Source Okta: unit tests were added #14927

merged 7 commits into from
Jul 22, 2022

Conversation

drrest
Copy link
Contributor

@drrest drrest commented Jul 21, 2022

What

added: UnitTests for Source Okta - coverage 100%

Recommended reading order

  1. y.python

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 21, 2022
@drrest drrest linked an issue Jul 21, 2022 that may be closed by this pull request
Source Okta. Cover functionality with unit tests to a minimal 90%. #14825
Closed
@drrest
Copy link
Contributor Author

drrest commented Jul 21, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2712589450
❌ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2712589450
🐛 https://gradle.com/s/qhontlveku7yg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0]
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
=================== 2 failed, 27 passed in 83.74s (0:01:23) ====================

@drrest drrest changed the title 🎉Source Okta: UnitTests was created 🎉Source Okta: unit tests was created Jul 21, 2022
@drrest
Copy link
Contributor Author

drrest commented Jul 21, 2022

/test connector=connectors/source-okta

@drrest drrest requested a review from lazebnyi July 21, 2022 22:03
@drrest
Copy link
Contributor Author

drrest commented Jul 22, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2717562629
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2717562629
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              298    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  964    246    74%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_okta/source.py       174      0   100%
source_okta/__init__.py       2      0   100%
---------------------------------------------
TOTAL                       176      0   100%

Build Passed

Test summary info:

All Passed

@bazarnov bazarnov changed the title 🎉Source Okta: unit tests was created 🎉Source Okta: unit tests were added Jul 22, 2022
@drrest drrest requested a review from lazebnyi July 22, 2022 12:23
@drrest drrest force-pushed the drrest/14825-full_unit_tests_for_source_okta branch from 852354a to f4165d2 Compare July 22, 2022 12:36
@drrest drrest merged commit 2e3ae72 into master Jul 22, 2022
@drrest drrest deleted the drrest/14825-full_unit_tests_for_source_okta branch July 22, 2022 14:45
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jul 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@arsenlosenko arsenlosenko arsenlosenko approved these changes

@bazarnov bazarnov bazarnov approved these changes

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/okta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Okta. Cover functionality with unit tests to a minimal 90%.
6 participants
@drrest @grubberr @arsenlosenko @bazarnov @lazebnyi @octavia-squidington-iii